0

Hi,

I got error "No value given for one or more required parameters" error when executing the following code. I checked the value of the query and it seems correct. Does anyone know why?

string connectionString = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\\Users\\Catherine\\Documents\\LearningCSharp.accdb";
            OleDbConnection myConnection = new OleDbConnection(connectionString);
            myConnection.Open();

            int employeeNumber = int.Parse(textBox1.Text);
            string name = textBox2.Text;
            string address = textBox3.Text;
            string query = "update EMPLOYEE set EmployeeName='"+ name + "', Address='"+ address + "' where EmployeeID = "+ employeeNumber;
            
            OleDbCommand myCommand = new OleDbCommand();
            myCommand.CommandText = query;
            myCommand.Connection = myConnection;
            myCommand.ExecuteNonQuery();

            myConnection.Close();

Thanks in advance.

7
Contributors
8
Replies
39
Views
7 Years
Discussion Span
Last Post by carrzkiss
0

Hi,

Check the input values are having single quote (') - if so handle with having double single quotes in replace command

ex: address.replace("'","''")

This issue arises when fields and input values are getting mismatched.

Let us know if this helps.

Good luck.

0

Thanks for your reply. I tried replace command but the issue persists.

I checked the value of query. It's like following:

"update EMPLOYEE set EmployeeName='Catherine Sea', Address='Vancouver, BC' where EmployeeID = 1"

Any problem with this?

0

>No value given for one or more required parameters.

Error says that the column name(s) or a table name in given query are not belongs to the table - Employee. Please open the .accdb and check/verify the name of columns/table.

Second, try to use parametrized queries.

0

I think you are not doing this correctly. i haven't touched ole for long now, but change your code to look like this

string connectionString = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\\Users\\Catherine\\Documents\\LearningCSharp.accdb";
        OleDbConnection myConnection = new OleDbConnection(connectionString);
        myConnection.Open();

        int employeeNumber = int.Parse(textBox1.Text);
        string name = textBox2.Text;
        string address = textBox3.Text;
        string query = "update EMPLOYEE set EmployeeName=[B] ?[/B] , Address=[B]?[/B] where EmployeeID = [B]?[/B]";

        OleDbCommand myCommand = new OleDbCommand();
        myCommand.Parameters.Add("@name").value =  name;
 myCommand.Parameters.Add("@employeeNumber").value = address;
 myCommand.Parameters.Add("@employeeNumber").value = employeeNumber;
        myCommand.CommandText = query;
        myCommand.Connection = myConnection;
        myCommand.ExecuteNonQuery();

        myConnection.Close();[/CODE]

The Sequence of the parameters must be the same. That means the first "?" must correspond to the first definition of the parameter. you got that error because your sql statement tells ado.net that there is a parameter and when it look it does not find any definition of a parameter.

Thanks in advance.

Edited by Reverend Jim: Fixed formatting

0

Thanks for all your reply. I have found the cause. I wrote a column name wrongly....

I also tried vuyiswamb's suggestion. But it seems it does not let me call command like "myCommand.Parameters.Add("@name").value = name;" directly. Instead I used the code like following:

string connectionString = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\\Users\\Amy Jia\\Documents\\LearningCSharp.accdb";
            OleDbConnection myConnection = new OleDbConnection(connectionString);
            myConnection.Open();

            int employeeNumber = int.Parse(textBox1.Text);
            string name = textBox2.Text;
            string address = textBox3.Text;
            string query = "update EMPLOYEE set EmployeeName=@name, EmployeeAddr=@address where EmployeeID =@employeeNumber";

            OleDbCommand myCommand = new OleDbCommand();

            myCommand.Parameters.Add("@name",OleDbType.VarChar);
            myCommand.Parameters.Add("@address", OleDbType.VarChar);
            myCommand.Parameters.Add("@employeeNumber", OleDbType.VarChar);

            myCommand.Parameters["@name"].Value = name;
            myCommand.Parameters["@address"].Value = address;
            myCommand.Parameters["@employeenumber"].Value = employeeNumber;

            myCommand.CommandText = query;
            myCommand.Connection = myConnection;
            myCommand.ExecuteNonQuery();

            myConnection.Close();

Cheers,

0

anyone can help me.
i have the same problem..

Imports System.Data.OleDb
Public Class Form3
    Public connString As String = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=HSMS.accdb"
    Dim conn As New OleDbConnection
    Dim myqry As String = Nothing
    Dim mycmd As New OleDbCommand
    Dim mydr As OleDbDataReader

    Dim str As String = Nothing
    Private Sub Form3_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        Call LVsettings()
        Call ConnToDB()
        Call FillListview()
        Call Set1()

    End Sub
#Region "FillListView"

    Sub FillListview()
        LV.Items.Clear()
        myqry = "SELECT * from Hardware"
        mycmd = New OleDbCommand(myqry, conn)
        mydr = mycmd.ExecuteReader

        While mydr.Read
            With LV
                .Items.Add(mydr("Component_ID"))
                With .Items(.Items.Count - 1).SubItems
                    '.Add(mydr("Component_ID"))
                    .Add(mydr("Product"))
                    .Add(mydr("Model"))
                    .Add(mydr("DO_Purchase"))
                    .Add(mydr("Contract_Duration"))
                    .Add(mydr("Purchase_Price"))
                    .Add(mydr("Supplier"))
                    .Add(mydr("Maintenance"))
                    .Add(mydr("Warranty_End"))
                    .Add(mydr("Description"))
                    .Add(mydr("Dept_ID"))
                    .Add(mydr("Location"))
                    .Add(mydr("Owner"))
                End With
            End With
        End While
    End Sub

#End Region

#Region "Connection"
    Sub ConnToDB()
        Try
            With conn
                If .State = ConnectionState.Open Then .Close()
                .ConnectionString = "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=HSMS.accdb"
                .Open()
            End With
        Catch ex As Exception
            MessageBox.Show("Unable to connect", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
            Application.Exit()
        End Try
    End Sub
#End Region

#Region "LVSettings"
    Sub LVsettings()
        With LV.Columns
            .Add("Component_ID", 100, HorizontalAlignment.Left)
            .Add("Product", 100, HorizontalAlignment.Left)
            .Add("Model", 100, HorizontalAlignment.Left)
            .Add("DO_Purchasee", 100, HorizontalAlignment.Left)
            .Add("Contract_Duration", 100, HorizontalAlignment.Left)
            .Add("Purchase_Price", 100, HorizontalAlignment.Left)
            .Add("Supplier", 100, HorizontalAlignment.Left)
            .Add("Maintenance", 100, HorizontalAlignment.Left)
            .Add("Warranty_End", 100, HorizontalAlignment.Left)
            .Add("Description", 100, HorizontalAlignment.Left)
            .Add("Dept_ID", 100, HorizontalAlignment.Left)
            .Add("Location", 100, HorizontalAlignment.Left)
            .Add("Owner", 100, HorizontalAlignment.Left)
        End With
    End Sub
#End Region

#Region "object Settings "

    Sub Set1()
        btnAdd.Enabled = True
        btnUpdate.Enabled = True
        btnDelete.Enabled = True
        btnback.Enabled = True

        btnSave.Enabled = False
        btnCancel.Enabled = False
        Dim txt As Control
        For Each txt In Me.Controls
            If TypeOf txt Is TextBox Then
                txt.Enabled = False
            End If
        Next

        LV.Enabled = True
    End Sub

    Sub Set2()
        btnAdd.Enabled = False
        btnUpdate.Enabled = False
        btnDelete.Enabled = False
        btnback.Enabled = False

        btnSave.Enabled = True
        btnCancel.Enabled = True

        Dim txt As Control
        For Each txt In Me.Controls
            If TypeOf txt Is TextBox Then
                txt.Enabled = True
            End If
        Next

        LV.Enabled = False
    End Sub
#End Region

#Region "CLEAR TEXTBOX"
    Sub ClearAlltextBox()
        ComboBox1.SelectedItem = Nothing
        ComboBox2.SelectedItem = Nothing
        ComboBox3.SelectedItem = Nothing

        Dim a As Control
        For Each a In Me.Controls
            If TypeOf a Is TextBox Then
                a.Text = Nothing
            End If
        Next
    End Sub
#End Region

    Private Sub btnExit_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnExit.Click
        Application.Exit()
    End Sub

    Private Sub btnback_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnback.Click, btnExit.Click
        Me.Hide()
        Form2.Show()
    End Sub

    Private Sub btnAdd_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnAdd.Click
        str = "add"

        Call Set2()
        Call ClearAlltextBox()
        

    End Sub

    Private Sub btnUpdate_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnUpdate.Click
        If TextBox1.Text = "" Then
            MessageBox.Show("Please Select Record to Update", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
        Else
            str = "update"
            Call Set2()
            'TextBox1.Enabled = True
        End If
    End Sub

    Private Sub btnCancel_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnCancel.Click
        Call Set1()
        Call ClearAlltextBox()
       
    End Sub


    Private Sub btnSave_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnSave.Click
        If str = "add" Then
            ''''''ADD NEW RECORD'''''''
            If TextBox1.Text = "" Or ComboBox1.SelectedItem = "" Or TextBox3.Text = "" Then
                MessageBox.Show("All fields Are Required", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
            Else
                myqry = "INSERT INTO Hardware (Component_ID, Product, Model, DO_Purchase, Contract_Duration, Purchase_Price, Supplier, Maintenance, Warranty_End, Description, Dept_ID, Location, Owner)"
                myqry = myqry + "VALUES('" & TextBox1.Text & "','" & ComboBox1.SelectedItem & "','" & TextBox3.Text & "','" & DateTimePicker1.Value.Date & "','" & TextBox2.Text & "','" & TextBox4.Text & "','" & TextBox5.Text & "','" & TextBox6.Text & "','" & DateTimePicker2.Value.Date & "','" & TextBox7.Text & "','" & ComboBox2.SelectedItem & "','" & ComboBox3.SelectedItem & "','" & TextBox10.Text & "')"
                mycmd = New OleDbCommand
                With mycmd
                    .CommandText = myqry
                    .Connection = conn
                    .ExecuteNonQuery()
                End With
                Call Set1()
            End If

        Else
            ''''''''''UPDATE RECORD'''''''
            If TextBox1.Text = "" Or ComboBox1.SelectedItem = "" Or TextBox3.Text = "" Or TextBox2.Text = "" Or TextBox4.Text = "" Or TextBox5.Text = "" Or TextBox6.Text = "" Then
                MessageBox.Show("All fields Are Required", "Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
                Call Set1()
            Else
                myqry = "UPDATE Hardware SET"
                'myqry = myqry + " Component_ID = '" & TextBox1.Text & "',"
                myqry = myqry + " Product = '" & ComboBox1.SelectedItem & "',"
                myqry = myqry + " Model = '" & TextBox3.Text & "',"
                myqry = myqry + " DO_Purchase = '" & DateTimePicker1.Value.Date & "',"
                myqry = myqry + " Contract_Duration = '" & TextBox2.Text & "',"
                myqry = myqry + " Purchase_Price = '" & TextBox4.Text & "',"
                myqry = myqry + " Supplier = '" & TextBox5.Text & "',"
                myqry = myqry + " Maintenance = '" & TextBox6.Text & "',"
                myqry = myqry + " Warranty_End = '" & DateTimePicker2.Value.Date & "',"
                myqry = myqry + " Description = '" & TextBox7.Text & "',"
                myqry = myqry + " Dept_ID = '" & ComboBox2.SelectedItem & "',"
                myqry = myqry + " Location = '" & ComboBox3.SelectedItem & "',"
                myqry = myqry + " Owner = '" & TextBox10.Text & "'"
                myqry = myqry + " WHERE "
                myqry = myqry + " Component_ID = " & TextBox1.Text



                mycmd = New OleDbCommand(myqry, conn)
                mycmd.ExecuteNonQuery()<-----No value given for one or more required parameters.
                Call Set1()
            End If
        End If

        Call FillListview()
        Call ClearAlltextBox()

    End Sub

    Private Sub btnDelete_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles btnDelete.Click
        If MsgBox("Are you sure you want to delete this record?", MsgBoxStyle.Question + MsgBoxStyle.YesNo) = MsgBoxResult.Yes Then
            myqry = "DELETE FROM Hardware WHERE Component_ID = " & TextBox1.Text
            mycmd = New OleDbCommand(myqry, conn)
            mycmd.ExecuteNonQuery()<----No value given for one or more required parameters.
        End If
        Call ClearAlltextBox()
        Call FillListview()
    End Sub

    Private Sub LV_SelectedIndexChanged(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles LV.SelectedIndexChanged
        If LV.SelectedItems.Count > 0 Then
            With LV.SelectedItems(0)
                TextBox1.Text = .Text
                ComboBox1.SelectedItem = .SubItems(1).Text
                TextBox3.Text = .SubItems(2).Text
                DateTimePicker1.Value = .SubItems(3).Text
                TextBox2.Text = .SubItems(4).Text
                TextBox4.Text = .SubItems(5).Text
                TextBox5.Text = .SubItems(6).Text
                TextBox6.Text = .SubItems(7).Text
                DateTimePicker2.Value = .SubItems(8).Text
                TextBox7.Text = .SubItems(9).Text
                ComboBox2.SelectedItem = .SubItems(10).Text
                ComboBox3.SelectedItem = .SubItems(11).Text
                TextBox10.Text = .SubItems(12).Text
            End With
        End If
    End Sub


End Class

I HAVE PROBLEM WHEN DELETE AND UPDATE

This question has already been answered. Start a new discussion instead.
Have something to contribute to this discussion? Please be thoughtful, detailed and courteous, and be sure to adhere to our posting rules.