JavaScript problem in FF

[pojke]

Hi,
I got very very strange problem. Since 19 of december, when all FireFox in company was upgrated automaticaly, code below stopped working. Strange thing is, when i wanted to solve it, it started to work when i've putted alert() function. Here you have working and not working examples. I'll add that this function is used about 4 times on the site:

NOT WORKING SCRIPT:

function loadJSintoDIV(id, url, switchdiv) {
    obj = document.getElementById(id);

    if(obj.innerHTML == '' || !switchdiv) {
        oelem=document.createElement("script");
        oelem.src=url;
        oelem.type="text/javascript";
        oelem.defer=true;
        document.getElementsByTagName("head")[0].appendChild(oelem);

        obj.style.height = '';
        obj.style.visibility = 'visible';
    } else {
        obj.innerHTML = '';
        obj.style.height = '0px';
        obj.style.visibility = 'hidden';
    }
}

WORKING SCRIPT:

function loadJSintoDIV(id, url, switchdiv) {
     obj = document.getElementById(id);
     alert('test');
     if(obj.innerHTML == '' || !switchdiv) {
         oelem=document.createElement("script");
         oelem.src=url;
         oelem.type="text/javascript";
         oelem.defer=true;
         document.getElementsByTagName("head")[0].appendChild(oelem);
 
         obj.style.height = '';
         obj.style.visibility = 'visible';
     } else {
         obj.innerHTML = '';
         obj.style.height = '0px';
         obj.style.visibility = 'hidden';
     }
 }

When press "ok" in alert popup, it works, without alert....crap...:?:

Any ideas whats wrong?

[MattEvans]

Where, or if you prefer when, is this code executed?

To be precise, what event* do you use to execute the function?

I ask that because, (I'll go out on a limb here) the code may be being executed as the page loads, but (perhaps) the script can only function correctly when the page is loaded fully. Forcing you to answer a modal message box {via alert()} causes the execution of the remainder of the function to be temporarily paused, meaning that when the important parts of the function are executed, the page has loaded.

Like I hope that I implied, that's an assumption founded on a working knowledge rather than any practical tests or even directly related experience**. The easiest way to find out if this is the case is to try putting the alert() after the function's main body, and posting back what happens.

Also; do say where the code is called from/when it is called.

*'inside script tags' is a viable event of sorts.
**or infact, a complete understanding of what you're trying to achieve. If you're calling this function from a user invoked event (like a click) on a fully loaded page; I have no idea.

[pojke]

OK,

First of all, the function is loaded from *.js file.
Then it is called 6 or 7 times on one page by call like this:

loadJSintoDIV('emailsList', 'crm_overview_emails.php?unique=emailsList&thr_id={$thr_id}&kon_id={$kon_id}&List_Eml_ID={$get.List_Eml_ID}', true); //code in {...} is Smarty

Now, first load of page. If the last parameter is true, div is still hidden. If false, div is loaded by appendChild(). Of course, later every part of page can be hidden and loaded by button, but it is working.
The problem is, that while page is loading 3 functions have last parameter false, so 3 parts normally was loaded. After last FF update only first is loaded, and other 2 is not.
Starting to work with alert, as i said...
Any ideas?

[MattEvans]

what happens if you try this code:

function loadJSintoDIV(id, url, switchdiv) {
     obj = document.getElementById(id);
     if(obj.innerHTML == '' || !switchdiv) {
         oelem=document.createElement("script");
         oelem.src=url;
         oelem.type="text/javascript";
         oelem.defer=true;
         document.getElementsByTagName("head")[0].appendChild(oelem);
 
         obj.style.height = '';
         obj.style.visibility = 'visible';
     } else {
         obj.innerHTML = '';
         obj.style.height = '0px';
         obj.style.visibility = 'hidden';
     }
     alert('test');
 }

Notice the movement of the alert() line. This isn't an attempt to solve your problem, but let me know if it has the same effect as having the alert() line first, or if there is a difference

[pojke]

With an alert at the end... not working...

[MattEvans]

what about the event that calls that function during loading? is it called like this:

<body onload="loadJSintoDIV(etc);">
...

or like this:

<script type="text/javascript">
loadJSintoDIV(etc);
</script>

or by some other means?

[pojke]

The second way :

<script language="JavaScript">
loadJSintoDIV('emailsList', 'crm_overview_emails.php?unique=emailsList&thr_id={$thr_id}&kon_id={$kon_id}&List_Eml_ID={$get.List_Eml_ID}', true);
</script>

[MattEvans]

try the first way.

the second way executes at an arbitrary time (possibly as it is encountered and thus before the document is loaded); the first way executes when the document has finished loading.

[pojke]

Unfortunately i can't use straight the first way, its because every function call is in another file (p.e. mails in crm_mail.tpl, faxes in crm_fax.tpl, letters in crm_letters.tpl), so i need Smarty variables after <body> which is in _header.tpl (In one page is about 20 files loaded for whole system).
I can try change at the end document.getElementsByTagName("body")[0].onload but it needs reference to a function, so all 3 calls need to be put in one moment, and i'm not sure how long Smarty remember variables. I'll try...