Why not just keep it simple?
int vowels = 0;
int other = 0;
for (int i = 0; myarray[i] != '\0'; i++) {
switch (myarray[i]) {
case 'a':
case 'e':
case 'i':
case 'o':
case 'u':
++vowels;
break;
default:
++other;
break;
}
}
cout << "Vowels: " << vowels << '\n'
<< "Other: " << other << '\n';