I am trying to use the command foreach to create a drop down menu. That I can usually do, the problem is I am also adding some linking. Here is some my code:

$sql2 = "SELECT mn.map, mn.route FROM maps m JOIN map_name mn ON (m.map_name = mn.map) WHERE `ship`='".$POST."'";
$result2 = mysql_query($sql2)
or die("Query Error".mysql_error());
while ($row = mysql_fetch_array($result2)) {
$mapname[$row] = $row;

<form action="edit_map_which.php" method="post">
<table border=0 cellspacing=1>
Map :
<SELECT name="map">
<option value="" SELECTED>Select a Map</option>
foreach( $mapname as $map => $route ){ **
<option value="<?php echo $map ?>"><?php echo $route ?></option>
<?php }
<INPUT type="submit" name="Submit" value="Submit">

** I get the error Invalid argument supplied for foreach() for this line.

I've tried quite a few different things for this, and I now feel like I am beating my head against the wall. Thanks for the help.

12 Years
Discussion Span
Last Post by Roberdin

Sounds like that your query is pulling nothing. What I would do, is above the while() section of your code, add

$mapname = array();

This will force $mapname to be an array - otherwise, if your query pulls nothing, then the while() block won't be interpreted and hence your mapname is undefined. So when foreach() asks for it, it finds that its not an array and starts whining. Forcing $mapname to be an array will just mean that the foreach doesn't do anything if its empty.
Obviously, you need to put this code above wherever else that you may have used $mapname as it will destroy it first.
I do, however, have some concerns about your query.


Should ship, not in fact be, m.ship or mn.ship?

This topic has been dead for over six months. Start a new discussion instead.
Have something to contribute to this discussion? Please be thoughtful, detailed and courteous, and be sure to adhere to our posting rules.